Re: [PATCH] platform/x86: int3472/discrete: add LEDS_CLASS dependency

From: Sakari Ailus
Date: Thu Feb 09 2023 - 04:11:15 EST


On Wed, Feb 08, 2023 at 05:36:52PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> int3472 now fails to link when the LED support is disabled:
>
> x86_64-linux-ld: drivers/platform/x86/intel/int3472/led.o: in function `skl_int3472_register_pled':
> led.c:(.text+0xf4): undefined reference to `led_classdev_register_ext'
> x86_64-linux-ld: led.c:(.text+0x131): undefined reference to `led_add_lookup'
> x86_64-linux-ld: drivers/platform/x86/intel/int3472/led.o: in function `skl_int3472_unregister_pled':
> led.c:(.text+0x16b): undefined reference to `led_remove_lookup'
> x86_64-linux-ld: led.c:(.text+0x177): undefined reference to `led_classdev_unregister'
>
> Add an explicit Kconfig dependency.
>
> Fixes: 5ae20a8050d0 ("platform/x86: int3472/discrete: Create a LED class device for the privacy LED")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Reviewed-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>

--
Sakari Ailus