Re: [PATCH 1/2] dt-bindings: soc: renesas: renesas.yaml: add renesas,rzn1d400-eb compatible

[Clément Léger]

Le Thu, 9 Feb 2023 09:48:09 +0100,
Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> a écrit :

> Hi Clément,
> 
> On Tue, Feb 7, 2023 at 3:52 PM Clément Léger <clement.leger@xxxxxxxxxxx> wrote:
> > Add "renesas,rzn1d400-eb" which target the RZ/N1 EB board when a RZ/N1D-DB
> > daughter board is plugged on it.
> >
> > Signed-off-by: Clément Léger <clement.leger@xxxxxxxxxxx>  
> 
> Thanks for your patch!
> 
> > --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> > +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> > @@ -431,6 +431,12 @@ properties:
> >                - renesas,rzn1d400-db # RZN1D-DB (RZ/N1D Demo Board for the RZ/N1D 400 pins package)
> >            - const: renesas,r9a06g032
> >
> > +      - description: RZ/N1{D,S} EB
> > +        items:
> > +          - enum:
> > +              - renesas,rzn1d400-eb # RZN1D-EB (Expansion Board when using a RZN1D-DB)
> > +          - const: renesas,r9a06g032  
> 
> Don't you want to have "renesas,rzn1d400-db", too, in between the two
> other values?

Do you mean like that ?

 - enum:
    - renesas,rzn1d400-eb # RZN1D-EB (Expansion Board when using a
   RZN1D-DB)
 - const: renesas,rzn1d400-db
 - const: renesas,r9a06g032

And thus using compatible = "renesas,rzn1d400-eb",
"renesas,rzn1d400-db", "renesas,r9a06g032" in the EB dt I guess.

Thanks,

> 
> > +
> >        - description: RZ/Five and RZ/G2UL (R9A07G043)
> >          items:
> >            - enum:  
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds



-- 
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com