Re: [PATCH] m68k: allow PM menu options for COMPILE_TEST

[Geert Uytterhoeven]

Hi Randy,

On Thu, Feb 9, 2023 at 2:06 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> Allow PM options for COMPILE_TEST. This quietens a kconfig
> warning.
>
> This is similar to a patch for Sparc32 that was suggested by
> Arnd.
>
> WARNING: unmet direct dependencies detected for PM
>   Depends on [n]: !MMU [=y]
>   Selected by [y]:
>   - SUN20I_PPU [=y] && (ARCH_SUNXI || COMPILE_TEST [=y])
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Thanks for your patch!

> --- a/arch/m68k/Kconfig
> +++ b/arch/m68k/Kconfig
> @@ -126,7 +126,7 @@ menu "Kernel Features"
>
>  endmenu
>
> -if !MMU
> +if !MMU || COMPILE_TEST
>  menu "Power management options"

I think this is the wrong solution.
All other selects of PM are done by architecture/platform-gating
symbols, and none of them can be enabled for compile-testing.

So either SUN20I_PPU should depend on PM, or ARCH_SUNXI
should select PM.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds