Re: [PATCH 2/3] arm64: dts: qcom: ipq5332: enable the download mode support

[Kathiravan T]

On 2/9/2023 5:06 AM, Bjorn Andersson wrote:
> On Mon, Jan 30, 2023 at 10:31:54PM +0530, Kathiravan T wrote:
> > Enable the support for download mode to collect the RAM dumps if
> > system crashes, to perform the post mortem analysis.
> >
> > Signed-off-by: Kathiravan T <quic_kathirav@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/ipq5332.dtsi | 6 ++++++
> >   1 file changed, 6 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> > index 7f0ba2ec339c..6a1d0cc927ef 100644
> > --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> > @@ -70,6 +70,7 @@
> >   	firmware {
> >   		scm {
> >   			compatible = "qcom,scm-ipq5332", "qcom,scm";
> > +			qcom,dload-mode = <&tcsr 0x0>;
> >   		};
> >   	};
> >   
> > @@ -142,6 +143,11 @@
> >   				 <0>;
> >   		};
> >   
> > +		tcsr: syscon@193d100 {
> > +			compatible = "qcom,tcsr-ipq5332", "syscon";
> > +			reg = <0x0193d100 0x4>;
> Please map the entire TCSR_REGS here, and use qcom,dload-mode to encode
> the offset within this.


Sure, will fix it in V2.


> Thanks,
> Bjorn
>
> > +		};
> > +
> >   		sdhc: mmc@7804000 {
> >   			compatible = "qcom,ipq5332-sdhci", "qcom,sdhci-msm-v5";
> >   			reg = <0x07804000 0x1000>, <0x07805000 0x1000>;
> > --
> > 2.17.1