Re: [PATCH 2/2] sched/psi: iterate through cgroups directly

From: Kairui Song
Date: Thu Feb 09 2023 - 10:31:26 EST


Michal Koutný <mkoutny@xxxxxxxx> 于2023年2月9日周四 06:03写道:
> On Wed, Feb 08, 2023 at 02:15:12PM -0500, Johannes Weiner <hannes@xxxxxxxxxxx> wrote:
> > Please name these psi_groups_first() and psi_groups_next().
>
> One more suggestion: s/next/parent/ to avoid impression of (sub)tree
> iteration and consistence with cg-related iters.
>
> Thanks,
> Michal
>

Thanks for the review, I'll update the patch with using this new name.