Re: [PATCH v3] selftests: use printf instead of echo -ne

From: Shuah Khan
Date: Thu Feb 09 2023 - 20:10:24 EST


On 2/9/23 09:19, Guenter Roeck wrote:
On Thu, Feb 9, 2023 at 12:55 AM Guillaume Tucker
<guillaume.tucker@xxxxxxxxxxxxx> wrote:

Rather than trying to guess which implementation of "echo" to run with
support for "-ne" options, use "printf" instead of "echo -ne". It
handles escape characters as a standard feature and it is widespread
among modern shells.

Reported-by: "kernelci.org bot" <bot@xxxxxxxxxxxx>
Suggested-by: David Laight <David.Laight@xxxxxxxxxx>
Fixes: 3297a4df805d ("kselftests: Enable the echo command to print newlines in Makefile")
Fixes: 79c16b1120fe ("selftests: find echo binary to use -ne options")
Signed-off-by: Guillaume Tucker <guillaume.tucker@xxxxxxxxxxxxx>

Reviewed-by: Guenter Roeck <groeck@xxxxxxxxxxxx>


Thank you. Applied to linux-kselftest next for Linux 6.3-rc1.

thanks,
-- Shuah