Re: [PATCH v9 24/27] virt: gunyah: Add proxy-scheduled vCPUs

[Srivatsa Vaddagiri]

* Srivatsa Vaddagiri <quic_svaddagi@xxxxxxxxxxx> [2023-02-09 16:10:06]:

> * Elliot Berman <quic_eberman@xxxxxxxxxxx> [2023-01-20 14:46:23]:
> 
> > +static void gh_handle_mmio_return(struct gunyah_vcpu *vcpu, u64 *state)
> > +{
> > +	if (!vcpu->vcpu_run->mmio.is_write)
> > +		memcpy(&state[0], vcpu->vcpu_run->mmio.data, vcpu->vcpu_run->mmio.len);
> 
> Would be good to do a bound check on length of memcpy I think (in case 
> vcpu_run_resp->state_data[1] is wrong for example).

Sorry I meant to comment that for the other memcpy you had!

+               memcpy(vcpu->vcpu_run->mmio.data, &vcpu_run_resp->state_data[2],
+                       vcpu_run_resp->state_data[1]);