RE: [PATCH 2/6] iommu/vt-d: Implement hw_info for iommu capability query
From: Tian, Kevin
Date: Fri Feb 10 2023 - 02:33:01 EST
> From: Liu, Yi L <yi.l.liu@xxxxxxxxx>
> Sent: Thursday, February 9, 2023 12:17 PM
>
> From: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
>
> To support nested translation in the userspace, it should check the
> underlying hardware information for the capabilities.
remove this sentence. that belongs to next patch.
> +
> +/**
> + * struct iommu_device_info_vtd - Intel VT-d device info
> + *
> + * @flags: Must be set to 0
> + * @__reserved: Must be 0
> + * @cap_reg: Value of Intel VT-d capability register defined in chapter
> + * 11.4.2 of Intel VT-d spec.
> + * @ecap_reg: Value of Intel VT-d capability register defined in chapter
> + * 11.4.3 of Intel VT-d spec.
let's be specific with section name e.g. "11.4.2 Capability Register" so if
the chapter index is changed later people can still know where to look
at.
> + *
> + * Intel hardware iommu capability.
duplicated with the first line "Intel VT-d device info"