Re: [PATCH 2/2] arm64: tegra: Audio codec support on Jetson AGX Orin

From: Sameer Pujar
Date: Fri Feb 10 2023 - 04:04:32 EST




On 10-02-2023 14:15, Krzysztof Kozlowski wrote:
On 09/02/2023 15:36, Sameer Pujar wrote:
Jetson AGX Orin has onboard RT5640 audio codec. This patch adds the
codec device node and the bindings to I2S1 interface.

Signed-off-by: Sameer Pujar <spujar@xxxxxxxxxx>
---
.../dts/nvidia/tegra234-p3737-0000+p3701-0000.dts | 47 +++++++++++++++++++++-
1 file changed, 46 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
index 8a97478..5881fbf 100644
--- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
@@ -3,6 +3,7 @@

#include <dt-bindings/input/linux-event-codes.h>
#include <dt-bindings/input/gpio-keys.h>
+#include <dt-bindings/sound/rt5640.h>

#include "tegra234-p3701-0000.dtsi"
#include "tegra234-p3737-0000.dtsi"
@@ -49,7 +50,7 @@

i2s1_dap: endpoint {
dai-format = "i2s";
- /* placeholder for external codec */
+ remote-endpoint = <&rt5640_ep>;
};
};
};
@@ -2017,6 +2018,32 @@
status = "okay";
};

+ i2c@31e0000 {
+ status = "okay";
+

+ audio-codec@1c {
+ status = "okay";
Are you sure you need this?
I can drop this in v2 as it would be the default state and it is not disabled anywhere else. Thanks.