Re: [PATCH 1/7] usb: typec: ucsi: add PMIC Glink UCSI driver

[Neil Armstrong]

On 31/01/2023 10:16, Greg Kroah-Hartman wrote:
> On Mon, Jan 30, 2023 at 10:54:32AM +0100, Neil Armstrong wrote:
> > Introduce the UCSI PMIC Glink aux driver that communicates
> > with the aDSP firmware with the UCSI protocol which handles
> > the USB-C Port(s) Power Delivery.
> >
> > The UCSI messaging is necessary on newer Qualcomm SoCs to
> > provide USB role switch and altmode notifications.
> >
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > ---
> >   drivers/usb/typec/ucsi/Kconfig      |   7 +
> >   drivers/usb/typec/ucsi/Makefile     |   1 +
> >   drivers/usb/typec/ucsi/ucsi_glink.c | 321 ++++++++++++++++++++++++++++++++++++
> >   3 files changed, 329 insertions(+)
> >
> > diff --git a/drivers/usb/typec/ucsi/Kconfig b/drivers/usb/typec/ucsi/Kconfig
> > index 8f9c4b9f31f7..dee6069e46a2 100644
> > --- a/drivers/usb/typec/ucsi/Kconfig
> > +++ b/drivers/usb/typec/ucsi/Kconfig
> > @@ -58,4 +58,11 @@ config UCSI_STM32G0
> >   	  To compile the driver as a module, choose M here: the module will be
> >   	  called ucsi_stm32g0.
> >   
> > +config UCSI_PMIC_GLINK
> > +	tristate "UCSI Qualcomm PMIC GLINK Interface Driver"
> > +	depends on QCOM_PMIC_GLINK
>
> No way to test build this code without this option?

Nop, the QCOM_PMIC_GLINK is a build dependency, this can't be removed

> > +	help
> > +	  This driver enables UCSI support on platforms that expose UCSI
> > +	  interface as PMIC GLINK device.
>
> Module name when built?

OK will add a follow-patch if needed

Thanks,
Neil

> A follow-on patch can be sent, this is minor.
>
> thanks,
>
> greg k-h