Re: [PATCH v2 3/5] arm64: dts: qcom: sm8350: add dp controller

[Dmitry Baryshkov]

On 10/02/2023 16:18, Neil Armstrong wrote:
> On 10/02/2023 12:08, Dmitry Baryshkov wrote:
> > On 10/02/2023 12:34, Neil Armstrong wrote:
> > > Add the Display Port controller subnode to the MDSS node.
> > >
> > > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > > ---
> > >   arch/arm64/boot/dts/qcom/sm8350.dtsi | 82 
> > > +++++++++++++++++++++++++++++++++++-
> > >   1 file changed, 80 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi 
> > > b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> > > index d490ce84a022..eb636b7dffa7 100644
> > > --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> > > @@ -2862,13 +2862,20 @@ ports {
> > >                       port@0 {
> > >                           reg = <0>;
> > > -                        dpu_intf1_out: endpoint {
> > > -                            remote-endpoint = <&mdss_dsi0_in>;
> > > +                        dpu_intf0_out: endpoint {
> > > +                            remote-endpoint = <&mdss_dp_in>;
> >
> > No need to reorder these ports. Please add DP to the end.
>
> Right, but I'll keep the dpu_intf0_out label for this port,
> but having dpu_intf1_out, dpu_intf2_out then dpu_intf0_out isn't very 
> clean...

I don't have a strong opinion here. I think we can ignore it.

--
With best wishes
Dmitry