Re: [PATCH net-next v7 4/9] net: phy: export phy_check_valid() function

[Alexander H Duyck]

On Thu, 2023-02-09 at 10:51 +0100, Oleksij Rempel wrote:
> This function will be needed for genphy_c45_ethtool_get_eee() provided
> by next patch.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> ---
>  drivers/net/phy/phy.c | 4 ++--
>  include/linux/phy.h   | 1 +
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index 3378ca4f49b6..41cfb24c48c1 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -242,11 +242,11 @@ unsigned int phy_supported_speeds(struct phy_device *phy,
>   *
>   * Description: Returns true if there is a valid setting, false otherwise.
>   */
> -static inline bool phy_check_valid(int speed, int duplex,
> -				   unsigned long *features)
> +bool phy_check_valid(int speed, int duplex, unsigned long *features)
>  {
>  	return !!phy_lookup_setting(speed, duplex, features, true);
>  }
> +EXPORT_SYMBOL(phy_check_valid);
>  
>  /**
>   * phy_sanitize_settings - make sure the PHY is set to supported speed and duplex
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index c183a8a27986..7a8e541de3f3 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -1619,6 +1619,7 @@ int phy_start_aneg(struct phy_device *phydev);
>  int phy_aneg_done(struct phy_device *phydev);
>  int phy_speed_down(struct phy_device *phydev, bool sync);
>  int phy_speed_up(struct phy_device *phydev);
> +bool phy_check_valid(int speed, int duplex, unsigned long *features);
>  
>  int phy_restart_aneg(struct phy_device *phydev);
>  int phy_reset_after_clk_enable(struct phy_device *phydev);

Looks good to me.

Reviewed-by: Alexander Duyck <alexanderduyck@xxxxxx>