Re: [PATCH v3 07/12] net: ethernet: mtk_eth_soc: only write values if needed

From: Russell King (Oracle)
Date: Fri Feb 10 2023 - 16:44:40 EST


On Thu, Feb 09, 2023 at 11:31:51PM +0000, Daniel Golle wrote:
> + /* Setup the link timer and QPHY power up inside SGMIISYS */
> + link_timer = phylink_get_link_timer_ns(interface);
> + if (link_timer < 0)
> + return link_timer;

My comment on the previous iteration of this series applies here.

(this comment for net-next review tracking purposes.)

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!