Re: [PATCH v4 4/6] KEYS: X.509: Parse Key Usage

[Eric Snowberg]

> On Feb 9, 2023, at 8:48 PM, Jarkko Sakkinen <jarkko@xxxxxxxxxx> wrote:
> 
> On Mon, Feb 06, 2023 at 09:59:56PM -0500, Eric Snowberg wrote:
>> Parse the X.509 Key Usage.  The key usage extension defines the purpose of
>> the key contained in the certificate.
>> 
>>   id-ce-keyUsage OBJECT IDENTIFIER ::=  { id-ce 15 }
>> 
>>      KeyUsage ::= BIT STRING {
>>           digitalSignature        (0),
>>           contentCommitment       (1),
>>           keyEncipherment         (2),
>>           dataEncipherment        (3),
>>           keyAgreement            (4),
>>           keyCertSign             (5),
>>           cRLSign                 (6),
>>           encipherOnly            (7),
>>           decipherOnly            (8) }
>> 
>> If the keyCertSign or digitalSignature is set, store it in the
>> public_key structure.  This will be used in a follow on patch that
>> requires knowing the certificate key usage type.
> 
> It would be better to shortly explain why we want to know key usage
> type, rather than give zero information with "follow on patch”.

Ok, I will add this in the next round, thanks.