Re: [PATCH 1/6] iommu: Add new iommu op to get iommu hardware information

[Baolu Lu]

On 2023/2/10 15:28, Tian, Kevin wrote:
> > From: Liu, Yi L <yi.l.liu@xxxxxxxxx>
> > Sent: Thursday, February 9, 2023 12:17 PM
> > @@ -223,6 +224,11 @@ struct iommu_iotlb_gather {
> >   /**
> >    * struct iommu_ops - iommu ops and capabilities
> >    * @capable: check capability
> > + * @hw_info: IOMMU hardware capabilities. The type of the returned data
> > is
>
> is it 'info' or 'capability'?
>
> > + *           defined in include/uapi/linux/iommufd.h. The data buffer is
> > + *           allocated in the IOMMU driver and the caller should free it
> > + *           after use. Return the data buffer if success, or ERR_PTR on
> > + *	      failure.
> >    * @domain_alloc: allocate iommu domain
> >    * @probe_device: Add device to iommu driver handling
> >    * @release_device: Remove device from iommu driver handling
> > @@ -252,6 +258,7 @@ struct iommu_iotlb_gather {
> >    */
> >   struct iommu_ops {
> >   	bool (*capable)(struct device *dev, enum iommu_cap);
> > +	void *(*hw_info)(struct device *dev, u32 *length);
> >
> >   	/* Domain allocation and freeing by the iommu driver */
> >   	struct iommu_domain *(*domain_alloc)(unsigned
> > iommu_domain_type);
> > @@ -280,6 +287,7 @@ struct iommu_ops {
> >   	void (*remove_dev_pasid)(struct device *dev, ioasid_t pasid);
> >
> >   	const struct iommu_domain_ops *default_domain_ops;
> > +	enum iommu_device_data_type driver_type;
>
> the enum is called 'device_data_type' while the field is called 'driver_type'.

The enum is named from uAPI's p-o-v and driver_type is from IOMMU's.

> btw this new field is not documented above.

Yes. Will do that.

Best regards,
baolu