Re: [PATCH net-next v2 08/12] net: wwan: tmi: Add data plane transaction layer
From: Yanchao Yang (杨彦超)
Date: Sat Feb 11 2023 - 03:50:00 EST
On Mon, 2023-01-30 at 12:05 -0800, Jakub Kicinski wrote:
> On Sun, 29 Jan 2023 08:51:00 +0000 Yanchao Yang (杨彦超) wrote:
> > > Please try to make the series smaller than 17,770 :/
> > > Strip stuff down to minimal working version.
> > > I don't think anyone can review 17kLoC in one sitting :/
> >
> > Thank your suggestion. I agree with you. Considering both the
> > control
> > plane and data plane are the minimal function for TMI driver, other
> > functions can be removed and submitted after the initial version is
> > approved. The whole patch can be reduced about 2k lines. Is it ok?
> > Or
> > do you have any more suggestions? Please help share it.
>
> SGTM, thanks!
Hi Jakub,
Thank you for your suggestion. V3 is submitted, which has 13k lines.
It's reduced 4k+ lines compared with V2. Please help review it and
share your advice at your convenience.
Many thanks.
Yanchao.yang