Re: [PATCH 596/606] watchdog: ziirave_wdt: Convert to i2c's .probe_new()

[Guenter Roeck]

On 2/11/23 15:01, Uwe Kleine-König wrote:
> Hello,
>
> On Fri, Jan 27, 2023 at 11:32:04AM +0100, Uwe Kleine-König wrote:
> > On Fri, Nov 18, 2022 at 02:57:47PM -0800, Guenter Roeck wrote:
> > > On Fri, Nov 18, 2022 at 11:45:30PM +0100, Uwe Kleine-König wrote:
> > > > From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> > > >
> > > > The probe function doesn't make use of the i2c_device_id * parameter so it
> > > > can be trivially converted.
> > > >
> > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> > >
> > > Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> >
> > This patch hasn't made it into next yet. Is it still on your radar?
> >
> > My plans for this series is to complete the conversion after the next
> > merge window which should include most patches from this series.
> >
> > So I ask you to either take this patch during the next merge window or
> > accept that it will be applied together with the i2c core conversion
> > that drops .probe() with the i2c_device_id parameter.
>
> This got Guenter's R-b tag twice now, but the patch didn't appear yet in
> next. I'll prepare a series for Wolfram to apply via his i2c tree based
> on what is in next during the merge window with the idea to get the
> change early into next with an immutable tag. If you get this patch in
> during the merge window that would be ideal, but if not, I will take
> care of it and as announced will send it together with the i2c change.

It is in my watchdog-next tree, and we can only hope that Wim
will pick it up from there.

Guenter