Re: [PATCH v2 2/8] arm64: perf: Abstract system register accesses away
From: Marc Zyngier
Date: Sun Feb 12 2023 - 06:58:45 EST
On Fri, 10 Feb 2023 16:54:54 +0000,
Zaid Al-Bassam <zalbassam@xxxxxxxxxx> wrote:
>
> From: Marc Zyngier <marc.zyngier@xxxxxxx>
>
> As we want to enable 32bit support, we need to distanciate the
> PMUv3 driver from the AArch64 system register names.
>
> This patch moves all system register accesses to an architecture
> specific include file, allowing the 32bit counterpart to be
> slotted in at a later time.
>
> Signed-off-by: Marc Zyngier <marc.zyngier@xxxxxxx>
> Co-developed-by: Zaid Al-Bassam <zalbassam@xxxxxxxxxx>
> Signed-off-by: Zaid Al-Bassam <zalbassam@xxxxxxxxxx>
> Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx>
> Link: https://lore.kernel.org/r/20230126204444.2204061-3-zalbassam@xxxxxxxxxx
You can drop these links. They were inserted when I picked your series
from the list, but they don't mean much at this stage.
> ---
> arch/arm64/include/asm/arm_pmuv3.h | 149 +++++++++++++++++++++++++++++
> drivers/perf/arm_pmuv3.c | 115 +++++-----------------
> include/linux/perf/arm_pmuv3.h | 45 +++++++++
> 3 files changed, 217 insertions(+), 92 deletions(-)
> create mode 100644 arch/arm64/include/asm/arm_pmuv3.h
>
> diff --git a/arch/arm64/include/asm/arm_pmuv3.h b/arch/arm64/include/asm/arm_pmuv3.h
> new file mode 100644
> index 0000000000000..eb204adb8dee2
> --- /dev/null
> +++ b/arch/arm64/include/asm/arm_pmuv3.h
> @@ -0,0 +1,149 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (C) 2012 ARM Ltd.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program. If not, see <http://www.gnu.org/licenses/>.
> + */
Please drop the license text, as we don't use this boilerplate anymore
(the SPDX tag is enough). Just keep:
/*
* Copyright (C) 2012 ARM Ltd.
*/
Thanks,
M.
--
Without deviation from the norm, progress is not possible.