RE: [EXT] [PATCH] octeontx2-pf: Remove repeating variable in test

[Subbaraya Sundeep Bhatta]

Hi,

> -----Original Message-----
> From: Deepak R Varma <drv@xxxxxxxxx>
> Sent: Saturday, February 11, 2023 3:16 PM
> To: Sunil Kovvuri Goutham <sgoutham@xxxxxxxxxxx>; Geethasowjanya Akula
> <gakula@xxxxxxxxxxx>; Subbaraya Sundeep Bhatta <sbhatta@xxxxxxxxxxx>;
> Hariprasad Kelam <hkelam@xxxxxxxxxxx>; David S. Miller
> <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub
> Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Cc: Saurabh Singh Sengar <ssengar@xxxxxxxxxxxxx>; Praveen Kumar
> <kumarpraveen@xxxxxxxxxxxxxxxxxxx>; Deepak R Varma <drv@xxxxxxxxx>
> Subject: [EXT] [PATCH] octeontx2-pf: Remove repeating variable in test
> 
> External Email
> 
> ----------------------------------------------------------------------
> No need to & a variable with itself. Remove extra variable from the expression.
> Change allows to realign code and improve readability.
> Issue identified using doublebitand.cocci Coccinelle semantic patch.
> 
> Signed-off-by: Deepak R Varma <drv@xxxxxxxxx>
> ---
>  drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c
> b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c
> index 684cb8ec9f21..66a27ee5ca56 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c
> @@ -792,8 +792,7 @@ static int otx2_prepare_ipv6_flow(struct
> ethtool_rx_flow_spec *fsp,
>  		}
> 
>  		/* NPC profile doesn't extract AH/ESP header fields */
> -		if ((ah_esp_mask->spi & ah_esp_hdr->spi) ||
> -		    (ah_esp_mask->tclass & ah_esp_mask->tclass))
> +		if ((ah_esp_mask->spi & ah_esp_hdr->spi) || ah_esp_mask-
> >tclass)

It is a typo. Below is the correct one:
                           if ((ah_esp_mask->spi & ah_esp_hdr->spi) ||
		   (ah_esp_mask->tclass & ah_esp_hdr->tclass))

Thanks,
Sundeep

>  			return -EOPNOTSUPP;
> 
>  		if (flow_type == AH_V6_FLOW)
> --
> 2.34.1
> 
>