Re: [PATCH 05/10] drm/msm/dsi: dsi_cfg: Deduplicate identical structs

[Konrad Dybcio]

On 11.02.2023 16:52, Dmitry Baryshkov wrote:
> On 11/02/2023 13:51, Konrad Dybcio wrote:
>> Some structs were defined multiple times for no apparent reason.
>> Deduplicate them.
>>
>> Fixes: 3f3c8aff1f8f ("drm/msm/dsi: Add configuration for 8x76")
>> Fixes: 3a3ff88a0fc1 ("drm/msm/dsi: Add 8x96 info in dsi_cfg")
>> Fixes: 6125bd327e16 ("drm/msm: add DSI support for sc7180")
>> Fixes: 65c391b31994 ("drm/msm/dsi: Add DSI support for SC7280")
> 
> I think we should drop these Fixes headers. There are no issues to be fixed in those versions. The code was inefficient and resulted in duplication of data, but that's all.
I see. I won't object!

Konrad
> 
> Other than that:
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> 
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
>> ---
>>   drivers/gpu/drm/msm/dsi/dsi_cfg.c | 77 +++++++++++--------------------
>>   1 file changed, 26 insertions(+), 51 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
>> index 5f62c563bd1c..860681bfc084 100644
>> --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c
>> +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
>> @@ -47,41 +47,32 @@ static const struct msm_dsi_config msm8974_apq8084_dsi_cfg = {
>>       },
>>   };
>>   -static const char * const dsi_8916_bus_clk_names[] = {
>> +static const char * const dsi_v1_3_1_clk_names[] = {
>>       "mdp_core", "iface", "bus",
>>   };
>>   -static const struct regulator_bulk_data msm8916_dsi_regulators[] = {
>> +static const struct regulator_bulk_data dsi_v1_3_1_regulators[] = {
>>       { .supply = "vdda", .init_load_uA = 100000 },    /* 1.2 V */
>>       { .supply = "vddio", .init_load_uA = 100000 },    /* 1.8 V */
>>   };
>>     static const struct msm_dsi_config msm8916_dsi_cfg = {
>>       .io_offset = DSI_6G_REG_SHIFT,
>> -    .regulator_data = msm8916_dsi_regulators,
>> -    .num_regulators = ARRAY_SIZE(msm8916_dsi_regulators),
>> -    .bus_clk_names = dsi_8916_bus_clk_names,
>> -    .num_bus_clks = ARRAY_SIZE(dsi_8916_bus_clk_names),
>> +    .regulator_data = dsi_v1_3_1_regulators,
>> +    .num_regulators = ARRAY_SIZE(dsi_v1_3_1_regulators),
>> +    .bus_clk_names = dsi_v1_3_1_clk_names,
>> +    .num_bus_clks = ARRAY_SIZE(dsi_v1_3_1_clk_names),
>>       .io_start = {
>>           { 0x1a98000, 0 },
>>       },
>>   };
>>   -static const char * const dsi_8976_bus_clk_names[] = {
>> -    "mdp_core", "iface", "bus",
>> -};
>> -
>> -static const struct regulator_bulk_data msm8976_dsi_regulators[] = {
>> -    { .supply = "vdda", .init_load_uA = 100000 },    /* 1.2 V */
>> -    { .supply = "vddio", .init_load_uA = 100000 },    /* 1.8 V */
>> -};
>> -
>>   static const struct msm_dsi_config msm8976_dsi_cfg = {
>>       .io_offset = DSI_6G_REG_SHIFT,
>> -    .regulator_data = msm8976_dsi_regulators,
>> -    .num_regulators = ARRAY_SIZE(msm8976_dsi_regulators),
>> -    .bus_clk_names = dsi_8976_bus_clk_names,
>> -    .num_bus_clks = ARRAY_SIZE(dsi_8976_bus_clk_names),
>> +    .regulator_data = dsi_v1_3_1_regulators,
>> +    .num_regulators = ARRAY_SIZE(dsi_v1_3_1_regulators),
>> +    .bus_clk_names = dsi_v1_3_1_clk_names,
>> +    .num_bus_clks = ARRAY_SIZE(dsi_v1_3_1_clk_names),
>>       .io_start = {
>>           { 0x1a94000, 0x1a96000, 0 },
>>       },
>> @@ -107,10 +98,6 @@ static const struct msm_dsi_config msm8994_dsi_cfg = {
>>       },
>>   };
>>   -static const char * const dsi_8996_bus_clk_names[] = {
>> -    "mdp_core", "iface", "bus", "core_mmss",
>> -};
>> -
>>   static const struct regulator_bulk_data msm8996_dsi_regulators[] = {
>>       { .supply = "vdda", .init_load_uA = 18160 },    /* 1.25 V */
>>       { .supply = "vcca", .init_load_uA = 17000 },    /* 0.925 V */
>> @@ -121,8 +108,8 @@ static const struct msm_dsi_config msm8996_dsi_cfg = {
>>       .io_offset = DSI_6G_REG_SHIFT,
>>       .regulator_data = msm8996_dsi_regulators,
>>       .num_regulators = ARRAY_SIZE(msm8996_dsi_regulators),
>> -    .bus_clk_names = dsi_8996_bus_clk_names,
>> -    .num_bus_clks = ARRAY_SIZE(dsi_8996_bus_clk_names),
>> +    .bus_clk_names = dsi_6g_bus_clk_names,
>> +    .num_bus_clks = ARRAY_SIZE(dsi_6g_bus_clk_names),
>>       .io_start = {
>>           { 0x994000, 0x996000, 0 },
>>       },
>> @@ -167,24 +154,20 @@ static const struct msm_dsi_config sdm660_dsi_cfg = {
>>       },
>>   };
>>   -static const char * const dsi_sdm845_bus_clk_names[] = {
>> +static const char * const dsi_v2_4_clk_names[] = {
>>       "iface", "bus",
>>   };
>>   -static const char * const dsi_sc7180_bus_clk_names[] = {
>> -    "iface", "bus",
>> -};
>> -
>> -static const struct regulator_bulk_data sdm845_dsi_regulators[] = {
>> +static const struct regulator_bulk_data dsi_v2_4_regulators[] = {
>>       { .supply = "vdda", .init_load_uA = 21800 },    /* 1.2 V */
>>   };
>>     static const struct msm_dsi_config sdm845_dsi_cfg = {
>>       .io_offset = DSI_6G_REG_SHIFT,
>> -    .regulator_data = sdm845_dsi_regulators,
>> -    .num_regulators = ARRAY_SIZE(sdm845_dsi_regulators),
>> -    .bus_clk_names = dsi_sdm845_bus_clk_names,
>> -    .num_bus_clks = ARRAY_SIZE(dsi_sdm845_bus_clk_names),
>> +    .regulator_data = dsi_v2_4_regulators,
>> +    .num_regulators = ARRAY_SIZE(dsi_v2_4_regulators),
>> +    .bus_clk_names = dsi_v2_4_clk_names,
>> +    .num_bus_clks = ARRAY_SIZE(dsi_v2_4_clk_names),
>>       .io_start = {
>>           { 0xae94000, 0xae96000, 0 },
>>       },
>> @@ -198,32 +181,24 @@ static const struct msm_dsi_config sm8550_dsi_cfg = {
>>       .io_offset = DSI_6G_REG_SHIFT,
>>       .regulator_data = sm8550_dsi_regulators,
>>       .num_regulators = ARRAY_SIZE(sm8550_dsi_regulators),
>> -    .bus_clk_names = dsi_sdm845_bus_clk_names,
>> -    .num_bus_clks = ARRAY_SIZE(dsi_sdm845_bus_clk_names),
>> +    .bus_clk_names = dsi_v2_4_clk_names,
>> +    .num_bus_clks = ARRAY_SIZE(dsi_v2_4_clk_names),
>>       .io_start = {
>>           { 0xae94000, 0xae96000, 0 },
>>       },
>>   };
>>   -static const struct regulator_bulk_data sc7180_dsi_regulators[] = {
>> -    { .supply = "vdda", .init_load_uA = 21800 },    /* 1.2 V */
>> -};
>> -
>>   static const struct msm_dsi_config sc7180_dsi_cfg = {
>>       .io_offset = DSI_6G_REG_SHIFT,
>> -    .regulator_data = sc7180_dsi_regulators,
>> -    .num_regulators = ARRAY_SIZE(sc7180_dsi_regulators),
>> -    .bus_clk_names = dsi_sc7180_bus_clk_names,
>> -    .num_bus_clks = ARRAY_SIZE(dsi_sc7180_bus_clk_names),
>> +    .regulator_data = dsi_v2_4_regulators,
>> +    .num_regulators = ARRAY_SIZE(dsi_v2_4_regulators),
>> +    .bus_clk_names = dsi_v2_4_clk_names,
>> +    .num_bus_clks = ARRAY_SIZE(dsi_v2_4_clk_names),
>>       .io_start = {
>>           { 0xae94000, 0 },
>>       },
>>   };
>>   -static const char * const dsi_sc7280_bus_clk_names[] = {
>> -    "iface", "bus",
>> -};
>> -
>>   static const struct regulator_bulk_data sc7280_dsi_regulators[] = {
>>       { .supply = "vdda", .init_load_uA = 8350 },    /* 1.2 V */
>>   };
>> @@ -232,8 +207,8 @@ static const struct msm_dsi_config sc7280_dsi_cfg = {
>>       .io_offset = DSI_6G_REG_SHIFT,
>>       .regulator_data = sc7280_dsi_regulators,
>>       .num_regulators = ARRAY_SIZE(sc7280_dsi_regulators),
>> -    .bus_clk_names = dsi_sc7280_bus_clk_names,
>> -    .num_bus_clks = ARRAY_SIZE(dsi_sc7280_bus_clk_names),
>> +    .bus_clk_names = dsi_v2_4_clk_names,
>> +    .num_bus_clks = ARRAY_SIZE(dsi_v2_4_clk_names),
>>       .io_start = {
>>           { 0xae94000, 0xae96000, 0 },
>>       },
>