Re: [PATCH 2/2] arm64: dts: qcom: sm8550-qrd: add QRD8550

[Krzysztof Kozlowski]

On 13/02/2023 12:14, Konrad Dybcio wrote:
> 
> 
> On 10.02.2023 17:38, Krzysztof Kozlowski wrote:
>> Add a minimal DTS for the new QRD8550 board - a mobile-like development
>> board with SM8550.  Serial, UFS and USB should be working.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>>
>> ---
>>
> [...]
>> +
>> +		vreg_l17b_2p5: ldo17 {
>> +			regulator-name = "vreg_l17b_2p5";
>> +			regulator-min-microvolt = <2504000>;
>> +			regulator-max-microvolt = <2504000>;
>> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>> +		};
> 
> [...]
> 
>> +		};
>> +
>> +		vreg_l1g_1p2: ldo1 {
>> +			regulator-name = "vreg_l1g_1p2";
>> +			regulator-min-microvolt = <1200000>;
>> +			regulator-max-microvolt = <1200000>;
>> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>> +		};
>> +
>> +		vreg_l3g_1p2: ldo3 {
>> +			regulator-name = "vreg_l3g_1p2";
>> +			regulator-min-microvolt = <1200000>;
>> +			regulator-max-microvolt = <1200000>;
>> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>> +		};
>> +	};
> 
> [...]
> 
>> +
>> +&ufs_mem_hc {
>> +	reset-gpios = <&tlmm 210 GPIO_ACTIVE_LOW>;
>> +	vcc-supply = <&vreg_l17b_2p5>;
>> +	vcc-max-microamp = <1300000>;
>> +	vccq-supply = <&vreg_l1g_1p2>;
>> +	vccq-max-microamp = <1200000>;
>> +	vccq2-supply = <&vreg_l3g_1p2>;
> None of these regulators have allowed-modes + allow-set-load,
> I think you may want that.
> 
> With or without that:
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

It's something to fix also for SM8550 MTP.

Best regards,
Krzysztof