RE: [PATCH v5 1/1] tty: n_gsm: add keep alive support

From: Starke, Daniel
Date: Mon Feb 13 2023 - 06:32:57 EST


> > From: Daniel Starke <daniel.starke@xxxxxxxxxxx>
> > + u32 keep_alive; /* Control channel keep-alive in ms */
> [...]
> > + if (dlci && !dlci->dead)
> > + mod_timer(&gsm->ka_timer, jiffies + gsm->keep_alive * HZ / 100);
>
> keep-alive is in ms? or in 10ms?

Good found. The comment is wrong. It is in 10ms as also written in the
comment for "keep_alive" within gsmmux.h to be in line with t1 and t2.
I will correct this for v6 of the patch.

Best regards,
Daniel Starke