Re: [PATCH V3 4/7] pinctrl: qcom: Add IPQ9574 pinctrl driver

[Devi Priya]

Thanks Bjorn for taking time to review the patch

On 2/9/2023 4:44 AM, Bjorn Andersson wrote:
> On Mon, Jan 30, 2023 at 06:25:25PM +0530, devi priya wrote:
> > +static const struct msm_pingroup ipq9574_groups[] = {
> > +	PINGROUP(0, sdc_data, qspi_data, qdss_traceclk_b, _, _, _, _, _, _),
> > +	PINGROUP(1, sdc_data, qspi_data, qdss_tracectl_b, _, _, _, _, _, _),
> > +	PINGROUP(2, sdc_data, qspi_data, qdss_tracedata_b, _, _, _, _, _, _),
> > +	PINGROUP(3, sdc_data, qspi_data, qdss_tracedata_b, _, _, _, _, _, _),
> > +	PINGROUP(4, sdc_cmd, qspi_cs, qdss_tracedata_b, _, _, _, _, _, _),
> > +	PINGROUP(5, sdc_clk, qspi_clk, qdss_tracedata_b, _, _, _, _, _,
> > +		 _),
>
> Please avoid line wrapping these, it just makes it hard to read.
Yes, we have addressed this comment part of V7 series
https://lore.kernel.org/linux-arm-kernel/20230206103337.21000-5-quic_devipriy@xxxxxxxxxxx/
> [..]
> > +};
> > +
> > +/* Reserving GPIO59 for controlling the QFPROM LDO regulator */
>
> This seems like a property of the board, please use gpio-reserved-ranges
> in the DT node instead.
As the GPIO is forbidden on SoC IPQ9574,
we have moved it to the pinctrl driver based on the suggestions received
in V1 series
https://lore.kernel.org/linux-arm-kernel/675ed9f7-da31-6206-5089-1db22025ef4b@xxxxxxxxxx/
> Thanks,
> Bjorn
Best Regards,
Devi Priya