Re: [PATCH 3/4] splice: Use init_sync_kiocb() in filemap_splice_read()

[Matthew Wilcox]

On Mon, Feb 13, 2023 at 01:46:18PM +0000, David Howells wrote:
> Use init_sync_kiocb() in filemap_splice_read() rather than open coding it
> and filter out IOCB_NOWAIT since the splice is synchronous.

If the user has asked for NOWAIT and the splice is going to be
synchronous, shouldn't we rather return -EWOULDBLOCK here?  Or
does this not block?

IOW, this either does the wrong thing, or it does something that's
irrelevant.