Re: [PATCH 05/12] pata_parport: remove typedef struct PIA

[Sergey Shtylyov]

On 2/11/23 5:42 PM, Ondrej Zary wrote:

> Remove typedef struct PIA and use struct pi_adapter directly.

   Prolly worth mentioning that you drop the spaces in the parameter lists
while at it...

> Signed-off-by: Ondrej Zary <linux@xxxxxxx>

Reviewed-by: Sergey Shtylyov <s.shtylyov@xxxxxx>

   Had some comments tho...

[...]
> diff --git a/drivers/ata/pata_parport/fit2.c b/drivers/ata/pata_parport/fit2.c
> index 28de8e4e41c3..020c93dea362 100644
> --- a/drivers/ata/pata_parport/fit2.c
> +++ b/drivers/ata/pata_parport/fit2.c
> @@ -37,13 +37,13 @@ devices.
>  
>  */
>  
> -static void  fit2_write_regr( PIA *pi, int cont, int regr, int val)
> +static void  fit2_write_regr(struct pi_adapter *pi, int cont, int regr, int val)

   Could also kill an extra space after *void*...

[...]
> diff --git a/drivers/ata/pata_parport/fit3.c b/drivers/ata/pata_parport/fit3.c
> index 0366f3123508..03f314ad5ee7 100644
> --- a/drivers/ata/pata_parport/fit3.c
> +++ b/drivers/ata/pata_parport/fit3.c
> @@ -39,7 +39,7 @@
>  
>  */
>  
> -static void  fit3_write_regr( PIA *pi, int cont, int regr, int val)
> +static void  fit3_write_regr(struct pi_adapter *pi, int cont, int regr, int val)

   Here as well...

[...]
> diff --git a/drivers/ata/pata_parport/kbic.c b/drivers/ata/pata_parport/kbic.c
> index 9a99b9e35d41..e065f8367716 100644
> --- a/drivers/ata/pata_parport/kbic.c
> +++ b/drivers/ata/pata_parport/kbic.c
[...]
> @@ -72,7 +72,7 @@ static int kbic_read_regr( PIA *pi, int cont, int regr )
>  	return -1;
>  }       
>  
> -static void  kbic_write_regr( PIA *pi, int cont, int regr, int val)
> +static void  kbic_write_regr(struct pi_adapter *pi, int cont, int regr, int val)

   And here...

[...]
> diff --git a/drivers/ata/pata_parport/ktti.c b/drivers/ata/pata_parport/ktti.c
> index d87eb3c139bc..bddd13b4801f 100644
> --- a/drivers/ata/pata_parport/ktti.c
> +++ b/drivers/ata/pata_parport/ktti.c
> @@ -29,7 +29,7 @@
>  
>  static int  cont_map[2] = { 0x10, 0x08 };
>  
> -static void  ktti_write_regr( PIA *pi, int cont, int regr, int val)
> +static void  ktti_write_regr(struct pi_adapter *pi, int cont, int regr, int val)

   And here...

[...] 

MBR, Sergey