Re: [PATCH] EDAC/amd64: remove unneeded call to reserve_mc_sibling_devs()

[Tom Rix]

On 2/13/23 12:28 PM, Nathan Chancellor wrote:
> On Mon, Feb 13, 2023 at 09:23:47PM +0100, Borislav Petkov wrote:
> > On Mon, Feb 13, 2023 at 08:12:38PM +0000, Yazen Ghannam wrote:
> > > These errors are encountered when extra warnings are enabled, correct?
> > It says so in the warning which one it is: -Werror,-Wsometimes-uninitialized
> >
> > Don't know if we enable that one for clang with W= or Nathan adds
> > additional switches.
> -Wsometimes-uninitialized is part of clang's -Wall so it is on by
> default in all builds, regardless of W=
>
> -Werror comes from CONFIG_WERROR, which is enabled with allmodconfig.
>
> > > I think the following patch would resolve this issue. This is part of a set
> > > that isn't fully applied.
> > > https://lore.kernel.org/linux-edac/20230127170419.1824692-12-yazen.ghannam@xxxxxxx/
> > >
> > > Boris,
> > > Do you think one of these patches should be applied or just hold off until the
> > > entire original set is applied?
> > I still wanted to go through the rest but I'm not sure I'll have time
> > for it before the merge window. So unless this is breaking some silly
> > testing scenario, I'd say I'll leave things as they are.
> This breaks allmodconfig with clang, so it would be great if one of
> these solutions was applied in the meantime.

This happens at least on allyesconfig clang W=1,2, i do not know about 
default, it's in a bad state as well.

It would be great if the clang build was working.

Nathan's patch is fine, go with that.

Tom

> Cheers,
> Nathan