Re: [PATCH v3 10/24] sparc: Remove COMMAND_LINE_SIZE from uapi

[WANG Xuerui]

On 2023/2/14 16:50, Sergey Shtylyov wrote:
> On 2/14/23 10:49 AM, Alexandre Ghiti wrote:
>
> > From: Palmer Dabbelt <palmer@xxxxxxxxxxxx>
> >
> > As far as I can tell this is not used by userspace and thus should not
> > be part of the user-visible API.
> >
> > Signed-off-by: Palmer Dabbelt <palmer@xxxxxxxxxxxx>
> > ---
> >   arch/sparc/include/asm/setup.h      | 6 +++++-
> >   arch/sparc/include/uapi/asm/setup.h | 7 -------
> >   2 files changed, 5 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/sparc/include/asm/setup.h b/arch/sparc/include/asm/setup.h
> > index 72205684e51e..d1384ed92547 100644
> > --- a/arch/sparc/include/asm/setup.h
> > +++ b/arch/sparc/include/asm/setup.h
> > @@ -7,7 +7,11 @@
> >   
> >   #include <linux/interrupt.h>
> >   
> > -#include <uapi/asm/setup.h>
> > +#if defined(__sparc__) && defined(__arch64__)
>
>     Mhm, I don't think these two can be #define'd simulaneously...

I believe it's just a SPARC-ism [1] [2] that may look strange and be 
easily confused for __aarch64__ (notice the extra 'a')...

[1]: 
https://github.com/gcc-mirror/gcc/blob/basepoints/gcc-12/gcc/config/sparc/sparc.h#L301
[2]: 
https://github.com/llvm/llvm-project/blob/llvmorg-17-init/clang/lib/Basic/Targets/Sparc.cpp#L241

--
WANG "xen0n" Xuerui

Linux/LoongArch mailing list: https://lore.kernel.org/loongarch/