Re: [PATCH v3 2/6] sign-file: move file signing logic to its own function

From: kernel test robot
Date: Tue Feb 14 2023 - 05:54:12 EST


Hi Shreenidhi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.2-rc8 next-20230214]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Shreenidhi-Shedi/sign-file-move-file-signing-logic-to-its-own-function/20230214-030302
patch link: https://lore.kernel.org/r/20230213190034.57097-2-sshedi%40vmware.com
patch subject: [PATCH v3 2/6] sign-file: move file signing logic to its own function
config: x86_64-randconfig-a003-20230213 (https://download.01.org/0day-ci/archive/20230214/202302141805.tULq9MiK-lkp@xxxxxxxxx/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/1dfab8ead8d3f9c0c04eeeaf7c436a2878f2158e
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Shreenidhi-Shedi/sign-file-move-file-signing-logic-to-its-own-function/20230214-030302
git checkout 1dfab8ead8d3f9c0c04eeeaf7c436a2878f2158e
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 prepare

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202302141805.tULq9MiK-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

scripts/sign-file.c:333:6: warning: unused variable 'i' [-Wunused-variable]
int i, n;
^
>> scripts/sign-file.c:318:5: warning: no previous prototype for function 'sign_file' [-Wmissing-prototypes]
int sign_file(int argc, char **argv, struct cmd_opts *opts)
^
scripts/sign-file.c:318:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int sign_file(int argc, char **argv, struct cmd_opts *opts)
^
static
2 warnings generated.
--
scripts/sign-file.c:333:6: warning: unused variable 'i' [-Wunused-variable]
int i, n;
^
>> scripts/sign-file.c:318:5: warning: no previous prototype for function 'sign_file' [-Wmissing-prototypes]
int sign_file(int argc, char **argv, struct cmd_opts *opts)
^
scripts/sign-file.c:318:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int sign_file(int argc, char **argv, struct cmd_opts *opts)
^
static
2 warnings generated.


vim +/sign_file +318 scripts/sign-file.c

317
> 318 int sign_file(int argc, char **argv, struct cmd_opts *opts)
319 {
320 struct module_signature sig_info = { .id_type = PKEY_ID_PKCS7 };
321 unsigned char buf[4096] = {0};
322 unsigned long module_size, sig_size;
323 unsigned int use_signed_attrs;
324 const EVP_MD *digest_algo;
325 EVP_PKEY *private_key;
326 #ifndef USE_PKCS7
327 CMS_ContentInfo *cms = NULL;
328 #else
329 PKCS7 *pkcs7 = NULL;
330 #endif
331 X509 *x509;
332 BIO *bd, *bm;
> 333 int i, n;
334
335 char *hash_algo = opts->hash_algo;
336 char *dest_name = opts->dest_name;
337 char *private_key_name = opts->private_key_name;
338 char *raw_sig_name = opts->raw_sig_name;
339 char *x509_name = opts->x509_name;
340 char *module_name = opts->module_name;
341 bool save_sig = opts->save_sig;
342 bool replace_orig = opts->replace_orig;
343 bool raw_sig = opts->raw_sig;
344 bool sign_only = opts->sign_only;
345

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests