Re: [PATCH 2/2] dt-bindings: rtc: nxp,pcf8563: add quartz-load-femtofarads for pcf85263 and pcf85363

[Javier Carrasco Cruz]

Hello,

Sorry for the previous mail in html format with annoying signatures.

> Hello,
>
> Krzysztof's confusion is because you are changing the binding for
> nxp,pcf8563 while adding support for the nxp,pcf85263/nxp,pcf85363

If that is ok I would propose a new bindings file nxp,pcf85363 for 
pcf85263 and pcf85363 in the next version.

Best regards,

Javier Carrasco

> On 13/02/2023 10:50:18+0100, Javier Carrasco wrote:
> > These RTCs are handled by the pcf85363 device driver, which now supports
> > the quartz-load-femtofarads property.
> >
> > Signed-off-by: Javier Carrasco <javier.carrasco@xxxxxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/rtc/nxp,pcf8563.yaml  | 20 ++++++++++++++++---
> >   1 file changed, 17 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml
> > index a98b72752349..aac7f7565ba7 100644
> > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml
> > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml
> > @@ -9,9 +9,6 @@ title: Philips PCF8563/Epson RTC8564 Real Time Clock
> >   maintainers:
> >     - Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> >   
> > -allOf:
> > -  - $ref: rtc.yaml#
> > -
> >   properties:
> >     compatible:
> >       enum:
> > @@ -37,6 +34,23 @@ properties:
> >     start-year: true
> >     wakeup-source: true
> >   
> > +allOf:
> > +  - $ref: rtc.yaml#
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - nxp,pcf85263
> > +              - nxp,pcf85363
> > +    then:
> > +      properties:
> > +        quartz-load-femtofarads:
> > +          description:
> > +            The capacitive load of the quartz(x-tal).
> > +          enum: [6000, 7000, 12500]
> > +          default: 7000
> > +
> >   required:
> >     - compatible
> >     - reg
> > --
> > 2.37.2
> >
> >
> > Javier Carrasco
> > Research and Development
> >
> > Wolfvision GmbH
> > Oberes Ried 14 | 6833 Klaus | Austria
> > Tel: +43 5523 52250 <tel:+43552352250> | Mail: javier.carrasco@xxxxxxxxxxxxxx <mailto:javier.carrasco@xxxxxxxxxxxxxx>
> >
> > Website: wolfvision.com <www.wolfvision.com>
> > Firmenbuch / Commercial Register: FN283521v Feldkirch/Austria