Re: [PATCH 1/2] dt-bindings: sound: ep93xx: Add I2S and AC'97 descriptions

[Alexander Sverdlin]

Hello Krzysztof,

thank you for the quick review!

On Tue, 2023-02-14 at 11:58 +0100, Krzysztof Kozlowski wrote:
> > +properties:
> > +  compatible:
> > +    const: cirrus,ep9301-i2s
> > +
> > +  '#sound-dai-cells':
> > +    const: 0
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    minItems: 3
> 
> maxItems instead

reg and clocks are required, I suppose I should include both minItems
and maxItems for both of them?

> > +
> > +  clock-names:
> > +    items:
> > +      - const: mclk
> > +      - const: sclk
> > +      - const: lrclk
> 
> 
> The clk suffixes are quite redundant. Don't these inputs have some
> meaningful name?

They are actually meaningful, as they are usually named in I2S, please
refer to the EP93xx User's Guide:
https://cdn.embeddedts.com/resource-attachments/ts-7000_ep9301-ug.pdf
page 71, for instance.

-- 
Alexander Sverdlin.