Re: [PATCH v7 1/5] dt-bindings: watchdog: mt7621-wdt: add phandle to access system controller registers

From: Guenter Roeck
Date: Tue Feb 14 2023 - 10:10:19 EST


On Tue, Feb 14, 2023 at 11:39:32AM +0100, Sergio Paracuellos wrote:
> MT7621 SoC provides a system controller node for accessing to some registers.
> Add a phandle in this node to avoid using MIPS related arch operations and
> includes in watchdog driver code.
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
> .../devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
> index b2b17fdf4e39..a668d0c2f14b 100644
> --- a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
> @@ -19,6 +19,12 @@ properties:
> reg:
> maxItems: 1
>
> + mediatek,sysctl:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description:
> + phandle to system controller 'sysc' syscon node which
> + controls system registers
> +
> required:
> - compatible
> - reg
> @@ -30,4 +36,5 @@ examples:
> watchdog@100 {
> compatible = "mediatek,mt7621-wdt";
> reg = <0x100 0x100>;
> + mediatek,sysctl = <&sysc>;
> };
> --
> 2.25.1
>