Re: [PATCH] module: fix MIPS module_layout -> module_memory
From: Randy Dunlap
Date: Tue Feb 14 2023 - 11:52:36 EST
On 2/13/23 23:22, Philippe Mathieu-Daudé wrote:
> Hi Randy,
>
> On 14/2/23 01:54, Randy Dunlap wrote:
>> Correct the struct's field/member name from mod_mem to mem.
>>
>> Fixes this build error:
>> ../arch/mips/kernel/vpe.c: In function 'vpe_elfload':
>> ../arch/mips/kernel/vpe.c:643:41: error: 'struct module' has no member named 'mod_mem'
>> 643 | v->load_addr = alloc_progmem(mod.mod_mem[MOD_TEXT].size);
>>
>> Fixes: 2ece476a2346 ("module: replace module_layout with module_memory")
>
> On which tree is your patch based?
linux-next-20230213.
> fatal: ambiguous argument '2ece476a2346': unknown revision or path not in the working tree.
>
>> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>> Cc: Song Liu <song@xxxxxxxxxx>
>> Cc: Luis Chamberlain <mcgrof@xxxxxxxxxx>
>> Cc: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>
>> Cc: linux-mips@xxxxxxxxxxxxxxx
>> ---
>> Has this already been fixed?
>>
>> arch/mips/kernel/vpe.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff -- a/arch/mips/kernel/vpe.c b/arch/mips/kernel/vpe.c
>> --- a/arch/mips/kernel/vpe.c
>> +++ b/arch/mips/kernel/vpe.c
>> @@ -640,7 +640,7 @@ static int vpe_elfload(struct vpe *v)
>> layout_sections(&mod, hdr, sechdrs, secstrings);
>> }
>> - v->load_addr = alloc_progmem(mod.mod_mem[MOD_TEXT].size);
>> + v->load_addr = alloc_progmem(mod.mem[MOD_TEXT].size);
>> if (!v->load_addr)
>> return -ENOMEM;
>>
>
--
~Randy