Re: [PATCH 11/12] riscv: dts: starfive: jh7100: Add sysmain and gmac DT nodes

[Cristian Ciocaltea]

On 2/13/23 11:26, Krzysztof Kozlowski wrote:
> On 11/02/2023 04:18, Cristian Ciocaltea wrote:
> > Provide the sysmain and gmac DT nodes supporting the DWMAC found on the
> > StarFive JH7100 SoC.
> >
> > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx>
> > ---
> >   arch/riscv/boot/dts/starfive/jh7100.dtsi | 38 ++++++++++++++++++++++++
> >   1 file changed, 38 insertions(+)
> >
> > diff --git a/arch/riscv/boot/dts/starfive/jh7100.dtsi b/arch/riscv/boot/dts/starfive/jh7100.dtsi
> > index 88f91bc5753b..0918af7b6eb0 100644
> > --- a/arch/riscv/boot/dts/starfive/jh7100.dtsi
> > +++ b/arch/riscv/boot/dts/starfive/jh7100.dtsi
> > @@ -164,6 +164,44 @@ rstgen: reset-controller@11840000 {
> >   			#reset-cells = <1>;
> >   		};
> >   
> > +		sysmain: syscon@11850000 {
> > +			compatible = "starfive,jh7100-sysmain", "syscon";
> > +			reg = <0x0 0x11850000 0x0 0x10000>;
> > +		};
> > +
> > +		gmac: ethernet@10020000 {
>
> Aren't the nodes ordered by address?

Right, I missed the ordering trying to keep the related nodes together. 
Will fix.

Thanks,
Cristian

> Best regards,
> Krzysztof