Re: [PATCH v1 2/4] dt-bindings: phy: Add starfive,jh7110-dphy-rx

From: Changhuang Liang
Date: Tue Feb 14 2023 - 20:28:08 EST




On 2023/2/14 15:49, Krzysztof Kozlowski wrote:
> On 14/02/2023 04:07, Changhuang Liang wrote:
>>
>> OK, will drop quotes
>>
>>>> + items:
>>>> + items:
>>>> + - description: phandle of AON SYSCON
>>>> + - description: register offset
>>>> + description: The register of dphy rx driver can be configured
>>>> + by AON SYSCON in this property.
>>>
>>> Can be? So does not have to? But you made it a required property....
>>>
>>
>> Maybe I described it wrong.
>> I will change to:
>> description: The power of dphy rx can be configured by AON SYSCON
>> in this property.
>> It is like AON SYSCON is the power switch of the dphy rx, it is necessary to
>> configure the AON SYSCON register, so I made it a required property.
>
> Then do not use "can be". Can is optional: I can jump but I don't have
> to. :)
>

OK, "can be" will be changed to "is".

Best Regards,
Changhuang Liang