Re: [PATCH 5/7] dt-bindings: clock: Add PCIe pipe clock definitions

[Devi Priya]

Thanks for taking time to review the patch!

On 2/15/2023 8:00 AM, Stephen Boyd wrote:
> Quoting Devi Priya (2023-02-14 08:41:33)
> > Add PCIe clock definitions for IPQ9574 SoC
> >
> > Co-developed-by: Anusha Rao <quic_anusha@xxxxxxxxxxx>
> > Signed-off-by: Anusha Rao <quic_anusha@xxxxxxxxxxx>
> > Signed-off-by: Devi Priya <quic_devipriy@xxxxxxxxxxx>
> > ---
> >   include/dt-bindings/clock/qcom,ipq9574-gcc.h | 276 ++++++++++---------
> >   1 file changed, 140 insertions(+), 136 deletions(-)
> >
> > diff --git a/include/dt-bindings/clock/qcom,ipq9574-gcc.h b/include/dt-bindings/clock/qcom,ipq9574-gcc.h
> > index feedfdd5e00a..c89e96d568c6 100644
> > --- a/include/dt-bindings/clock/qcom,ipq9574-gcc.h
> > +++ b/include/dt-bindings/clock/qcom,ipq9574-gcc.h
> > @@ -74,140 +74,144 @@
> >   #define GCC_PCIE3_AXI_S_BRIDGE_CLK                     65
> >   #define GCC_PCIE3_AXI_S_CLK                            66
> >   #define PCIE0_PIPE_CLK_SRC                             67
> > -#define PCIE1_PIPE_CLK_SRC                             68
>
> Just add the new define at the end. This number and define is ABI
> forever and shouldn't change.
Sure, will update
> > -#define PCIE2_PIPE_CLK_SRC                             69
> > -#define PCIE3_PIPE_CLK_SRC                             70
Best Regards,
Devi Priya