Re: [PATCH v2 0/3] can: esd_usb: Some more preparation for supporting esd CAN-USB/3

[Marc Kleine-Budde]

On 14.02.2023 17:02:20, Frank Jungclaus wrote:
> Another small batch of patches to be seen as preparation for adding
> support of the newly available esd CAN-USB/3 to esd_usb.c.
> 
> Due to some unresolved questions adding support for
> CAN_CTRLMODE_BERR_REPORTING has been postponed to one of the future
> patches.
> 
> *Resend of the whole series as v2 for easier handling.*

As Vincent pointed out in review of a completely different patch series,
bu this applies here, too:

| For the titles, please use imperative (e.g. add) instead of past tense
| (e.g. Added). This also applies to the description.

Further, the subject ob patches 1 and 2 can be improved a bit, e.g.
patch 1 could mention to move the SJA1000_ECC_SEG for a specific reason.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature