Re: [PATCH 3/3] rtc: mt6397: select IRQ_DOMAIN instead of depending on it

[AngeloGioacchino Del Regno]

Il 13/02/23 05:15, Randy Dunlap ha scritto:
> IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set
> it directly thru "make *config", so drivers should select it instead
> of depending on it if they need it.
> Relying on it being set for a dependency is risky.
>
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
>
> Therefore, change the use of "depends on" for IRQ_DOMAIN to
> "select" for RTC_DRV_MT6397.
>
> Fixes: 04d3ba70a3c9 ("rtc: mt6397: add IRQ domain dependency")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Eddie Huang <eddie.huang@xxxxxxxxxxxx>
> Cc: Sean Wang <sean.wang@xxxxxxxxxxxx>
> Cc: Matthias Brugger <matthias.bgg@xxxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-mediatek@xxxxxxxxxxxxxxxxxxx
> Cc: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>
> Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> Cc: linux-rtc@xxxxxxxxxxxxxxx
> Cc: Marc Zyngier <maz@xxxxxxxxxx>
> Cc: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> Cc: Peter Rosin <peda@xxxxxxxxxx>
> ---
> I have a similar patch (should be a series) for REGMAP.
>
>   drivers/rtc/Kconfig |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)