Re: [PATCH v3 bpf] bpf, test_run: fix &xdp_frame misplacement for LIVE_FRAMES

From: Alexander Lobakin
Date: Wed Feb 15 2023 - 13:19:09 EST


From: Martin Kafai Lau <martin.lau@xxxxxxxxx>
Date: Wed, 15 Feb 2023 10:04:51 -0800

> On 2/15/23 7:21 AM, Alexander Lobakin wrote:
>>   /* The maximum permissible size is: PAGE_SIZE - sizeof(struct
>> xdp_page_head) -
>> - * sizeof(struct skb_shared_info) - XDP_PACKET_HEADROOM = 3368 bytes
>> + * sizeof(struct skb_shared_info) - XDP_PACKET_HEADROOM = 3408 bytes
>>    */
>> -#define MAX_PKT_SIZE 3368
>> +#define MAX_PKT_SIZE 3408
>
> s390 has a different cache line size:
>
> https://lore.kernel.org/all/20230128000650.1516334-11-iii@xxxxxxxxxxxxx/
>
> The above s390 fix is in bpf-next. It is better to target this patch for
> bpf-next also such that the CI can test it in s390.
>

Oh, thanks for letting me know! Will do in a bit.

Thanks,
Olek