Re: [PATCH] power: reset: at91-sama5d2_shdwc: Use devm_platform_get_and_ioremap_resource()

[Claudiu.Beznea]

On 15.02.2023 08:50, ye.xingchen@xxxxxxxxxx wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> From: Ye Xingchen <ye.xingchen@xxxxxxxxxx>
> 
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Ye Xingchen <ye.xingchen@xxxxxxxxxx>

Reviewed-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>


> ---
>  drivers/power/reset/at91-sama5d2_shdwc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c
> index d8ecffe72f16..3142ac53782b 100644
> --- a/drivers/power/reset/at91-sama5d2_shdwc.c
> +++ b/drivers/power/reset/at91-sama5d2_shdwc.c
> @@ -331,7 +331,6 @@ static const struct of_device_id at91_pmc_ids[] = {
> 
>  static int __init at91_shdwc_probe(struct platform_device *pdev)
>  {
> -       struct resource *res;
>         const struct of_device_id *match;
>         struct device_node *np;
>         u32 ddr_type;
> @@ -349,8 +348,7 @@ static int __init at91_shdwc_probe(struct platform_device *pdev)
> 
>         platform_set_drvdata(pdev, at91_shdwc);
> 
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       at91_shdwc->shdwc_base = devm_ioremap_resource(&pdev->dev, res);
> +       at91_shdwc->shdwc_base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
>         if (IS_ERR(at91_shdwc->shdwc_base))
>                 return PTR_ERR(at91_shdwc->shdwc_base);
> 
> --
> 2.25.1