Re: [PATCH] mm/migrate: Fix wrongly apply write bit after mkdirty on sparc64
From: Peter Xu
Date: Thu Feb 16 2023 - 14:19:35 EST
On Thu, Feb 16, 2023 at 05:59:16PM +0100, Linux regression tracking (Thorsten Leemhuis) wrote:
> On 16.02.23 16:30, Peter Xu wrote:
> > Nick Bowler reported another sparc64 breakage after the young/dirty
> > persistent work for page migration (per "Link:" below). That's after a
> > similar report [2].
>
> Thx for handling this.
>
> > [...]
> >
> > Note: this is based on mm-unstable, because the breakage was since 6.1 and
> > we're at a very late stage of 6.2 (-rc8), so I assume for this specific
> > case we should target this at 6.3.
> >
> > [1] https://lore.kernel.org/all/20221021160603.GA23307@xxxxxxxxxxxx/
> > [2] https://lore.kernel.org/all/20221212130213.136267-1-david@xxxxxxxxxx/
> >
> > Cc: regressions@xxxxxxxxxxxxx
>
> Not that it matters much, but feel free to use this instead:
>
> CC: regressions@xxxxxxxxxxxxxxx
>
> Then things don't depend on me (in case I ever get help with my cat
> herding job). And it also make it even more obvious that this patch
> fixes a regression to anyone who handles it downstream.
Sure.
>
> > Fixes: 2e3468778dbe ("mm: remember young/dirty bit for page migrations")
>
> That's a commit from 6.1, hence this should likely have:
>
> Cc: stable@xxxxxxxxxxxxxxx # 6.1.y
>
> [no, a fixes tag alone does not suffice, see docs]
Oops, I just forgot that. We definitely need to cc:stable. I'll make sure
it's there if there's a new version, or I hope Andrew could help to attach
otherwise.
Thanks,
--
Peter Xu