Re: [PATCH v4 1/5] i2c: hpe: Add GXP SoC I2C Controller
From: Wolfram Sang
Date: Thu Feb 16 2023 - 15:47:43 EST
Hi Nick,
> I will work on the defines and get rid of all the magic values.
Cool, thank you!
> Unfortunately, there is no public spec available currently.
> Hopefully, we will have one someday though.
Then, the #defines are even more helpful!
> > drivers/i2c/busses/i2c-gxp.c: In function ‘gxp_i2c_probe’:
> > drivers/i2c/busses/i2c-gxp.c:533:28: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
> > 533 | drvdata->engine = ((u32)drvdata->base & 0xf00) >> 8;
>
> I am currently unable to reproduce this error. I even set W=2.
Interesting. I have this version:
gcc (Debian 10.2.1-6) 10.2.1 20210110
> Would replacing (u32) with (unsigned long) resolve it?
Or size_t.
Happy hacking,
Wolfram
Attachment:
signature.asc
Description: PGP signature