Re: [PATCH v2 34/47] clk: mediatek: Switch to module_platform_driver() where possible

[Chen-Yu Tsai]

On Tue, Feb 14, 2023 at 9:42 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@xxxxxxxxxxxxx> wrote:
>
> Lots of clock drivers have got both .probe() and a .remove() callbacks:
> switch from builtin_platform_driver() to module_platform_driver() so
> that we actually register the .remove() callback.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> ---
>  drivers/clk/mediatek/clk-mt2701-aud.c          | 3 +--
>  drivers/clk/mediatek/clk-mt2701-bdp.c          | 3 +--
>  drivers/clk/mediatek/clk-mt2701-eth.c          | 3 +--
>  drivers/clk/mediatek/clk-mt2701-g3d.c          | 3 +--
>  drivers/clk/mediatek/clk-mt2701-hif.c          | 3 +--
>  drivers/clk/mediatek/clk-mt2701-img.c          | 3 +--
>  drivers/clk/mediatek/clk-mt2701-mm.c           | 3 +--
>  drivers/clk/mediatek/clk-mt2701-vdec.c         | 3 +--
>  drivers/clk/mediatek/clk-mt2712-bdp.c          | 3 +--
>  drivers/clk/mediatek/clk-mt2712-img.c          | 3 +--
>  drivers/clk/mediatek/clk-mt2712-jpgdec.c       | 3 +--
>  drivers/clk/mediatek/clk-mt2712-mfg.c          | 3 +--
>  drivers/clk/mediatek/clk-mt2712-mm.c           | 3 +--
>  drivers/clk/mediatek/clk-mt2712-vdec.c         | 3 +--
>  drivers/clk/mediatek/clk-mt2712-venc.c         | 3 +--
>  drivers/clk/mediatek/clk-mt6765-audio.c        | 3 +--
>  drivers/clk/mediatek/clk-mt6765-cam.c          | 3 +--
>  drivers/clk/mediatek/clk-mt6765-img.c          | 3 +--
>  drivers/clk/mediatek/clk-mt6765-mipi0a.c       | 3 +--
>  drivers/clk/mediatek/clk-mt6765-mm.c           | 3 +--
>  drivers/clk/mediatek/clk-mt6765-vcodec.c       | 3 +--
>  drivers/clk/mediatek/clk-mt6797-img.c          | 3 +--
>  drivers/clk/mediatek/clk-mt6797-mm.c           | 3 +--
>  drivers/clk/mediatek/clk-mt6797-vdec.c         | 3 +--
>  drivers/clk/mediatek/clk-mt6797-venc.c         | 3 +--
>  drivers/clk/mediatek/clk-mt7622-aud.c          | 3 +--
>  drivers/clk/mediatek/clk-mt7622-eth.c          | 3 +--
>  drivers/clk/mediatek/clk-mt7622-hif.c          | 3 +--
>  drivers/clk/mediatek/clk-mt7629-eth.c          | 1 -

This one looks fishy. It wasn't converted to the simple probe library.

Otherwise,

Reviewed-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>