Re: [PATCH v2] octeontx2-pf: Use correct struct reference in test condition

From: Deepak R Varma
Date: Fri Feb 17 2023 - 02:55:41 EST


On Tue, Feb 14, 2023 at 08:28:41PM -0800, Jakub Kicinski wrote:
> On Mon, 13 Feb 2023 17:10:50 +0530 Deepak R Varma wrote:
> > Fix the typo/copy-paste error by replacing struct variable ah_esp_mask name
> > by ah_esp_hdr.
> > Issue identified using doublebitand.cocci Coccinelle semantic patch.
> >
> > Signed-off-by: Deepak R Varma <drv@xxxxxxxxx>
>
> Your patch did not make it to the list, please make sure or recipients
> are correct (common error is to lack a space between name and the
> address, e.g. "David S. Miller"<davem@xxxxxxxxxxxxx>).

Hello Jakub,
I again verified using the get_maintainer.pl script and did not find any issues
with the recipient list. Can you specify which mailing list it did not reach out
to please?

>
> When reposting please add a Fixes tag.

Sure. I will include this detail in the v3.

Thank you,
./drv

>
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c
> > index 684cb8ec9f21..10e11262d48a 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c
> > @@ -793,7 +793,7 @@ static int otx2_prepare_ipv6_flow(struct ethtool_rx_flow_spec *fsp,
> >
> > /* NPC profile doesn't extract AH/ESP header fields */
> > if ((ah_esp_mask->spi & ah_esp_hdr->spi) ||
> > - (ah_esp_mask->tclass & ah_esp_mask->tclass))
> > + (ah_esp_mask->tclass & ah_esp_hdr->tclass))
> > return -EOPNOTSUPP;
> >
> > if (flow_type == AH_V6_FLOW)
>