Re: [Patch] [tegra] Remove unneeded version.h includes pointed out by 'make versioncheck'

[Jon Hunter]

On 17/02/2023 09:30, Jon Hunter wrote:
> On 16/02/2023 00:53, Jesper Juhl wrote:
> >  From 7264ec7d00ece4b56fe9fafa3237d4870cbe6785 Mon Sep 17 00:00:00 2001
> > From: Jesper Juhl <jesperjuhl76@xxxxxxxxx>
> > Date: Mon, 13 Feb 2023 02:49:50 +0100
> > Subject: [PATCH 04/12] [tegra] Remove unneeded version.h includes 
> > pointed out
> >   by 'make versioncheck'
> >
> > Signed-off-by: Jesper Juhl <jesperjuhl76@xxxxxxxxx>
>
>
> The patch looks correct, but there is no commit message and I am not 
> sure why the header is in the body of the message. Make sure you use git 
> send-email to send patches.

Also the patch $subject prefix should match subsystem you are patching.
You can check this by looking at the git history ...

$ git log --oneline drivers/soc/tegra/cbb/
b6c6bbfc65f5 soc/tegra: cbb: Remove redundant dev_err call
fa9b5246e260 soc/tegra: cbb: Use DEFINE_SHOW_ATTRIBUTE to simplify tegra_cbb_err
2927cf85f487 soc/tegra: cbb: Check firewall before enabling error reporting
55084947d6b4 soc/tegra: cbb: Add checks for potential out of bound errors

So you want some like "soc/tegra: cbb: Remove unneeded version.h header"

Jon

--
nvpublic