Re: [PATCH] MIPS: dts: Boston: Fix dtc 'pci_device_reg' warning
From: Thomas Bogendoerfer
Date: Fri Feb 17 2023 - 06:05:49 EST
On Mon, Feb 13, 2023 at 02:24:51PM +0800, Genjian wrote:
> From: Genjian Zhang <zhanggenjian@xxxxxxxxxx>
>
> dtbs_check currently complains that:
> arch/mips/boot/dts/img/boston.dts:128.19-178.5: Warning (pci_device_reg):
> /pci@14000000/pci2_root@0,0,0: PCI unit address format error,
> expected "0,0"
> The unit-address format should be '<device>,<function>'.
> Fix the unit-address accordingly.
>
> Reported-by: k2ci <kernel-bot@xxxxxxxxxx>
> Signed-off-by: Genjian Zhang <zhanggenjian@xxxxxxxxxx>
> ---
> arch/mips/boot/dts/img/boston.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/boot/dts/img/boston.dts b/arch/mips/boot/dts/img/boston.dts
> index 84328afa3a55..72f7605d2e31 100644
> --- a/arch/mips/boot/dts/img/boston.dts
> +++ b/arch/mips/boot/dts/img/boston.dts
> @@ -125,7 +125,7 @@ pci2_intc: interrupt-controller {
> #interrupt-cells = <1>;
> };
>
> - pci2_root@0,0,0 {
> + pci2_root@0,0 {
> compatible = "pci10ee,7021";
> reg = <0x00000000 0 0 0 0>;
>
> --
> 2.25.1
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]