Re: [RFC v2 PATCH 6/7] x86/resctrl: Display the RMID and COSID for resctrl groups

[Moger, Babu]

On 2/16/2023 7:46 PM, Fenghua Yu wrote:
> Hi, Babu,
>
> On 2/2/23 13:47, Babu Moger wrote:
> > When a user creates a control or monitor group, the CLOSID or RMID
> > are not visible to the user. These are architecturally defined entities.
> > There is no harm in displaying these in resctrl groups. Sometimes it
> > can help to debug the issues.
> >
> > Add CLOSID and RMID to the control/monitor groups display in resctrl
> > interface.
> >
> > $cat /sys/fs/resctrl/clos1/closid
> > 1
> > $cat /sys/fs/resctrl/mon_groups/mon1/rmid
> > 3
> >
> > Signed-off-by: Babu Moger <babu.moger@xxxxxxx>
> > ---
> >   Documentation/x86/resctrl.rst          |   17 ++++++++++++
> >   arch/x86/kernel/cpu/resctrl/rdtgroup.c |   44 
> > ++++++++++++++++++++++++++++++++
> >   2 files changed, 61 insertions(+)
> >
> > diff --git a/Documentation/x86/resctrl.rst 
> > b/Documentation/x86/resctrl.rst
> > index 2c013c5d45fd..de332c242523 100644
> > --- a/Documentation/x86/resctrl.rst
> > +++ b/Documentation/x86/resctrl.rst
> > @@ -321,6 +321,15 @@ All groups contain the following files:
> >       Just like "cpus", only using ranges of CPUs instead of bitmasks.
> >     +"rmid":
> > +        Available only with debug option.Reading this file shows the
> > +        resource monitoring id (RMID) for monitoring the resource
>
> Capitals Resource Monitoring ID (RMID).
Sure.
> > +        utilization. Monitoring is performed by tagging each core(or
> > +        thread) or process via a Resource Monitoring ID (RMID). Kernel
>
> s/Resource Monitoring ID (RMID)/RMID/

Sure.

Thanks

Babu