RE: [PATCH v3 1/6] Update Kconfig and Makefile.

From: Elliott, Robert (Servers)
Date: Fri Feb 17 2023 - 16:45:23 EST


> +config CRYPTO_P10_AES_GCM
> + tristate "Stitched AES/GCM acceleration support on P10+ CPU (PPC)"
> + depends on PPC64 && POWER10_CPU && CPU_LITTLE_ENDIAN
> + select CRYPTO_LIB_AES
> + select CRYPTO_ALGAPI
> + select CRYPTO_AEAD
> + default m
> + help
> + Support for cryptographic acceleration instructions on Power10+ CPU.
> + This module supports stitched acceleration for AES/GCM in
> hardware.

Is "Power10+" a specific architecture or does that mean "Power10 or later"?

Please follow the newer wording conventions for the menu item and
help text, more like:

config CRYPTO_AES_GCM_PPC_P10
tristate "AEAD cipher: AES in GCM mode (Power10)"

help
AEAD cipher: AES cipher algorithms (FIPS-197) with
GCM (Galois/Counter Mode) authenticated encryption mode (NIST SP800-38D)

Architecture: powerpc64 using:
- little-endian
- Power10 features

[some description here]

Also, all the other powerpc cra_driver_names follow
alg-arch
not
arch-alg

so
.base.cra_driver_name = "p10_aes_gcm",
might be better as
.base.cra_driver_name = "aes-gcm-p10",

Patch 4 seems to have code for lots of other modes like CBC and XTS.
Does the perl script strip out all of that?