Re: [PATCH v4 11/11] fs/9p: Fix revalidate
From: asmadeus
Date: Sat Feb 18 2023 - 03:55:46 EST
Eric Van Hensbergen wrote on Sat, Feb 18, 2023 at 12:33:23AM +0000:
> Unclear if this case ever happens, but if no inode in dentry, then
> the dentry is definitely invalid. Seemed to be the opposite in the
> existing code.
Looking at other implementations of d_revalidate (ecryptfs, cifs, vfat)
it seems to be assumed that the inode is always valid.
I'd just remove the if, or if we keep it add a WARN or something for a
while so we can remove it in a few releases?
(That said, it's better to return 0 than 1 here, so don't take this for
a no -- progress is progress)
--
Dominique