Re: [PATCH net-next] net: phy: micrel: Add support for PTP_PF_PEROUT for lan8841

From: Horatiu Vultur
Date: Sat Feb 18 2023 - 07:10:52 EST


The 02/18/2023 01:55, Andrew Lunn wrote:
>
> > +static void lan8841_ptp_update_target(struct kszphy_ptp_priv *ptp_priv,
> > + const struct timespec64 *ts);
> > +
>
> Please avoid this. Move the code around so everything is in
> order. Generally, i do such moves in an initial patch which only moves
> code, making it easy to review.

Thanks for the suggestion. I will update this in the next version.

>
> Andrew

--
/Horatiu