Re: [PATCH] irq: ipi: fix NULL pointer deref in irq_data_get_affinity_mask()

From: Sergey Shtylyov
Date: Sun Feb 19 2023 - 05:20:37 EST


On 2/9/23 1:49 PM, Thomas Gleixner wrote:
[...]

>>> Iff ipi_send_{mask|single}() get called with e.g. an invalid IRQ #, all the
>>> local variables there will be NULL -- the problem is that ipi_send_verify()
>>> (that's called first thing) doesn't verify its 'data' parameter, resulting
>>> in a kernel oops in irq_data_get_affinity_mask() as the passed NULL pointer
>>> gets dereferenced. Add a missing NULL check in ipi_send_verify()...
>>>
>>> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
>>> analysis tool.
>>>
>>> Fixes: 3b8e29a82dd1 ("genirq: Implement ipi_send_mask/single()")
>>> Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
>>
>> Patch fell thru the cracks? :-/
>
> Obviously :)
>
> /me goes to find trash tongs to pick it up

Need help? :-)

MBR, Sergey